Skip to content

Rename FORMAT_LINKS setting to FORMAT_RELATED_LINKS #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

platinumazure
Copy link
Contributor

@platinumazure platinumazure commented Dec 28, 2020

Follow-up from #876.

Description of the Change

Rename JSON_API_FORMAT_LINKS setting to JSON_API_FORMAT_RELATED_LINKS for clarity.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added: Updated existing tests
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Waiting to merge this though till we get our CI running again (see #879)

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #878 (d43329a) into master (986df87) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #878   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          60       60           
  Lines        3320     3320           
=======================================
  Hits         3247     3247           
  Misses         73       73           
Impacted Files Coverage Δ
rest_framework_json_api/settings.py 100.00% <ø> (ø)
tests/test_relations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986df87...a26d633. Read the comment docs.

@platinumazure
Copy link
Contributor Author

@sliverc I rebased and force-pushed since it didn't seem like the actions wanted to run on existing PRs. Feel free to review and let me know if any issues were introduced... Thanks!

@sliverc
Copy link
Member

sliverc commented Dec 29, 2020

The actions seem to have run through now and are all green. Merging therefore. Thanks again.

@sliverc sliverc merged commit cfca644 into django-json-api:master Dec 29, 2020
@platinumazure platinumazure deleted the rename-format-links branch December 29, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants